Claude Code Review

Head SHA: 54f11a6

Files changed:

• 2
• toolchain/mfc/test/coverage.py
• toolchain/mfc/test/test_coverage_unit.py

Findings:

cases.py removal misses modifications to existing tests

The rationale ("new tests are conservatively included: not in cache → always runs") only covers the case where a brand-new test is added to cases.py. A test entry that already has a golden file has a stable UUID (CRC32 of its trace string). If an existing test's parameters are changed in cases.py without altering its trace string, the UUID stays the same, the golden file remains, and the coverage system has no .fpp signal to select that test — so the modified test never runs. A PR that changes only cases.py (modifying existing test parameters) would pass CI while exercising zero of the affected tests.

definitions.py removal misses changes to existing parameter defaults or constraints

The comment says "adding a parameter doesn't affect tests that don't use it", but definitions.py is also edited when default values, types, or constraint expressions are changed for existing parameters. Such changes can shift the generated .inp for every test that uses those parameters. With definitions.py removed from ALWAYS_RUN_ALL, a PR that only modifies a default value in definitions.py produces no .fpp coverage signal and runs no tests, leaving regressions undetected.

No actionable comments were generated in the recent review. 🎉

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 45.01%. Comparing base (2ffec9a) to head (54f11a6).
⚠️ Report is 3 commits behind head on master.

@@           Coverage Diff           @@
##           master    #1328   +/-   ##
=======================================
  Coverage   45.01%   45.01%           
=======================================
  Files          70       70           
  Lines       20562    20562           
  Branches     1962     1962           
=======================================
  Hits         9255     9255           
  Misses      10179    10179           
  Partials     1128     1128           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.